feat(Pagination): accessibility tweaks & add unit tests by suryansh-it · Pull Request #1903 · OWASP/Nest

suryansh-it · 2025-07-29T08:56:46Z

Proposed change

This is a clean version of the earlier PR #1879, which mistakenly included unrelated files.

Closes #1864
Replaces #1879

Summary

This PR introduces:

Accessibility improvements to the <Pagination /> component:
- type="button" on all <Button> elements to prevent unintended form submissions
- aria-current="page" on the active page for improved screen reader support
- aria-label="More pages" used for ellipsis indicators instead of data-testid
New unit tests in __tests__/unit/components/Pagination.test.tsx that cover:
- Conditional rendering (e.g. isLoaded = false, totalPages <= 1)
- Correct pagination number display across edge cases and large sets
- Prev/Next button enable/disable states
- Ellipsis logic and placement
- onPageChange callback functionality
- Accessibility features and styles

Checklist

I've read and followed the contributing guidelines.
I've run make check-test locally; all checks and tests passed.

…ipsis

…lbacks

coderabbitai · 2025-07-29T08:56:52Z

Summary by CodeRabbit

New Features
- Improved accessibility of the pagination controls, including clearer labeling for screen readers and better indication of the current page.
Tests
- Added comprehensive tests for the pagination component, covering rendering, navigation behavior, edge cases, and accessibility features.

Walkthrough

A new unit test suite was added for the <Pagination /> React component, covering rendering, behavior, event handling, edge cases, and accessibility. The component implementation was updated to improve accessibility by adding button types, aria attributes, and roles to relevant elements.

Changes

Cohort / File(s)	Change Summary
Pagination Component Tests `frontend/__tests__/unit/components/Pagination.test.tsx`	Added comprehensive unit tests for `<Pagination />` covering rendering, props, events, edge cases, and accessibility.
Pagination Component Accessibility `frontend/src/components/Pagination.tsx`	Added `type="button"` to all `<Button>` elements, improved ellipsis accessibility with `role` and `aria-label`, and set `aria-current="page"` on the active page button.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Renders successfully with minimal required props, Conditional rendering logic, Prop-based behavior, Event handling, State changes / internal logic, Default values and fallbacks, Text and content rendering, Handles edge cases and invalid inputs, Accessibility roles and labels, DOM structure / classNames / styles (#1864)	✅

Suggested reviewers

arkid15r

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42a6498 and 7aec5ec.

📒 Files selected for processing (2)

frontend/__tests__/unit/components/Pagination.test.tsx (1 hunks)
frontend/src/components/Pagination.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

frontend/src/components/Pagination.tsx
frontend/tests/unit/components/Pagination.test.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Run frontend e2e tests
GitHub Check: Run frontend unit tests
GitHub Check: Run backend tests

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

suryansh-it · 2025-07-29T09:05:31Z

This is a clean replacement for #1879, which included unrelated files by mistake.

Only the scoped changes for the Pagination component are included here:

Accessibility enhancements (aria-current, explicit type="button")
Unit tests covering navigation, edge cases, and ellipsis behavior

thanks for the earlier review! Looking forward to feedback on this cleaned-up version.

suryansh-it · 2025-07-30T05:51:42Z

I've verified the changes locally by running make check — all frontend-related tests and checks passed.

sonarqubecloud · 2025-08-01T01:14:08Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kasya · 2025-08-01T01:15:39Z

I've verified the changes locally by running make check — all frontend-related tests and checks passed.

It doesn't look like that 👀

Ensure you run it as the final step before committing your changes.

kasya

Thanks for adding accessibility issues!
Next time make sure you run make check before committing changes 👌🏼

suryansh-it · 2025-08-01T03:27:45Z

Thanks for adding accessibility issues! Next time make sure you run make check before committing changes 👌🏼

Thank you for the guidance and for bearing with me!☺️
I’ll definitely keep that in mind for future contributions.

suryansh-it added 3 commits July 27, 2025 17:23

feat(Pagination): add type=button, aria-current & data-testid for ell…

d7c17ea

…ipsis

test(Pagination): add unit tests covering rendering, edge cases & cal…

c858a55

…lbacks

feat(Pagination): accessibility tweaks & unit tests (clean)

8f4f46b

suryansh-it requested review from arkid15r and kasya as code owners July 29, 2025 08:56

github-actions bot added frontend frontend-tests labels Jul 29, 2025

suryansh-it mentioned this pull request Jul 29, 2025

Add Pagination Unit Tests & Accessibility Tweaks (Closes #1864) #1879

Closed

2 tasks

suryansh-it added 3 commits July 30, 2025 10:02

git commit -m "chore: restore package.json for CI to work"

42a6498

removed

73a2e29

removed incorrect files that were incorrectly added

d7a2de2

kasya and others added 6 commits July 30, 2025 20:36

Merge branch 'main' into pagination-clean

1d1afe8

Merge branch 'main' into pagination-clean

21134cf

Merge branch 'main' into pagination-clean

b6b27f5

Merge branch 'main' into pagination-clean

fad4f3d

Fix make check issues

654ffa8

Merge branch 'main' into pagination-clean

7aec5ec

kasya approved these changes Aug 1, 2025

View reviewed changes

kasya enabled auto-merge August 1, 2025 01:18

kasya added this pull request to the merge queue Aug 1, 2025

Merged via the queue into OWASP:main with commit 61f85d8 Aug 1, 2025
24 checks passed

coderabbitai bot mentioned this pull request Nov 16, 2025

Add aria-labels to interactive elements for WCAG 2.1 compliance #2657

Merged

2 tasks

coderabbitai bot mentioned this pull request Dec 11, 2025

Feat/add aria labels #2871

Closed

3 tasks

coderabbitai bot mentioned this pull request Dec 19, 2025

Prefer tag over ARIA role #2977

Merged

3 tasks

coderabbitai bot mentioned this pull request Jan 18, 2026

test: replace single-character regex alternation with character class #3400

Merged

4 tasks

This was referenced Feb 12, 2026

Improve frontend test coverage above 90% and add missing test files #3923

Merged

Add dual-theme coverage to all a11y tests and create missing component tests #3964

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(Pagination): accessibility tweaks & add unit tests#1903

feat(Pagination): accessibility tweaks & add unit tests#1903
kasya merged 12 commits intoOWASP:mainfrom
suryansh-it:pagination-clean

suryansh-it commented Jul 29, 2025

Uh oh!

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

suryansh-it commented Jul 29, 2025

Uh oh!

suryansh-it commented Jul 30, 2025

Uh oh!

sonarqubecloud bot commented Aug 1, 2025

Uh oh!

kasya commented Aug 1, 2025

Uh oh!

kasya left a comment

Uh oh!

Uh oh!

suryansh-it commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

suryansh-it commented Jul 29, 2025

Proposed change

Summary

Checklist

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

suryansh-it commented Jul 29, 2025

Uh oh!

suryansh-it commented Jul 30, 2025

Uh oh!

sonarqubecloud bot commented Aug 1, 2025

Quality Gate passed

Uh oh!

kasya commented Aug 1, 2025

Uh oh!

kasya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

suryansh-it commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

coderabbitai bot commented Jul 29, 2025 •

edited

Loading